Changeset 80713b0054beb5197e1a9a4347a066496a08d939

Timestamp:

12/02/09 21:24:04 (3 years ago)

Author:

Leo 'costela' Antunes <leo@…>

Parents:

e17861cf54208dc1c6dc231687cafc3ac2321d7d

git-committer:

Leo 'costela' Antunes <leo@…> (12/02/09 21:24:04)

Message:

minor reworking of the checkFreshness code

git-svn-id:  http://svn.costela.net/guck/trunk@51 0b27b881-053d-0410-9699-9726465f5fd6

Location:

src/classes

Files:

• base/View.class.php (modified) (2 diffs)
• view/PostsView.class.php (modified) (3 diffs)
• view/UsersView.class.php (modified) (2 diffs)

src/classes/base/View.class.php

@@ -230 +230 @@
         }
 
-        public static function checkFreshness($date) 
+        /**
+         * Generates appropriate headers, based on document age.
+         *
+         * @param int $time     timestamp with the last update of the document being generated
+         */
+        public static function checkFreshness($time)
         {
                 $since = strtotime($_SERVER['HTTP_IF_MODIFIED_SINCE']);
 
-                if( $since && $since > strtotime($date) )
+                if( $since && $since > $time )
                 {
                         header('HTTP/1.1 304 Not Modified');
@@ -241 +246 @@
                 else
                 {
-                        header('Last-Modified: '.gmdate('D, d M Y H:i:s', $date).' GMT');
-                        header('ETag: '.md5($date));
+                        header('Last-Modified: '.gmdate('D, d M Y H:i:s', $time).' GMT');
+                        header('ETag: '.md5($time));
                 }
         }

src/classes/view/PostsView.class.php

@@ -62 +62 @@
                 $posts = PostsLogic::getBatch($page);
                 
-                $this->view->checkFreshness($posts[0]->date);
+                $this->view->checkFreshness(strtotime($posts[0]->date));
 
                 $this->view->assign('posts', $posts);
@@ -74 +74 @@
                 
                 $posts = PostsLogic::getBatch($page, Logic::getConfig()->POSTS_PER_PAGE);
-                $this->view->checkFreshness($posts[0]->date);
+                $this->view->checkFreshness(strtotime($posts[0]->date));
 
                 $this->view->assign('posts', $posts);
@@ -83 +83 @@
         {
                 $posts = PostsLogic::getBatch(1, Logic::getConfig()->POSTS_PER_PAGE);
-                $this->view->checkFreshness($posts[0]->date);
+                $this->view->checkFreshness(strtotime($posts[0]->date));
 
                 $this->view->assign('posts', $posts);

src/classes/view/UsersView.class.php

@@ -49 +49 @@
                 $posts = PostsLogic::getBatchByUser($page, $userId);
 
-                $this->view->checkFreshness($posts[0]->date);
+                $this->view->checkFreshness(strtotime($posts[0]->date));
 
                 $this->view->assign('posts', $posts);
@@ -88 +88 @@
                 $posts = PostsLogic::getBatchByUser($page, $_GET['userId']);
 
-                $this->view->checkFreshness($posts[0]->date);
+                $this->view->checkFreshness(strtotime($posts[0]->date));
 
                 $this->view->assign('posts', $posts);